Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add packet flushing logic to timeout and timeout on close flows #3879

Closed
1 task done
crodriguezvega opened this issue Jun 17, 2023 · 1 comment
Closed
1 task done

Add packet flushing logic to timeout and timeout on close flows #3879

crodriguezvega opened this issue Jun 17, 2023 · 1 comment
Assignees
@DimitrisJim
Labels
04-channel channel-upgradability Channel upgradability feature
Milestone
04-channel upgrad...

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Jun 17, 2023 •
edited
Loading

Pre-requisite:

After deleting the packet commitment, change flush status to FLUSHCOMPLETE if the flush status is FLUSHING and there are no pending in-flight packets. Opening the issue for both Timeout and TimeoutOnClose since they both use TimeoutExecuted function and that's where the packet commitment is deleted, in case we decide to implement this logic inside that function.

See also question here.
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jun 17, 2023
@colin-axner colin-axner added the channel-upgradability Channel upgradability feature label Jun 19, 2023
@DimitrisJim DimitrisJim mentioned this issue Jun 22, 2023
Merged
9 tasks
@DimitrisJim DimitrisJim self-assigned this Jun 22, 2023
@DimitrisJim DimitrisJim moved this from Todo to In progress in ibc-go Jun 22, 2023
@DimitrisJim DimitrisJim moved this from In progress to In review in ibc-go Jun 29, 2023
@crodriguezvega
Copy link
Contributor Author

Closed by #3923.

@crodriguezvega crodriguezvega moved this from In review to Done in ibc-go Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
04-channel channel-upgradability Channel upgradability feature
Projects
ibc-go
Archived in project
Milestone
04-channel upgrades alpha
Development

No branches or pull requests
3 participants
@crodriguezvega @DimitrisJim @colin-axner