Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CosmosTx.GetBytes() #3918

Closed
3 tasks
Tracked by #3916
colin-axner opened this issue Jun 21, 2023 · 0 comments · Fixed by #5396
Closed
3 tasks
Tracked by #3916

Remove CosmosTx.GetBytes() #3918

colin-axner opened this issue Jun 21, 2023 · 0 comments · Fixed by #5396
Labels
type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

Summary

It is unused and leads to confusion. The expected encoding/decoding for the CosmosTx should be documented in the SerializeCosmosTx/DeserializeCosmosTx

The implementation of CosmosTx.GetBytes() doesn't match the actual serialization as the the GetBytes() uses proto3 json and the actual serialization is only proto

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Jun 21, 2023
@colin-axner colin-axner mentioned this issue Jun 21, 2023
Closed
9 tasks
@chandiniv1 chandiniv1 mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove cosmosTx.getbytes() chandiniv1/ibc-go
1 participant
@colin-axner