Delegate store operation of ClientState and ConsensusState in Initialize to contract

[crodriguezvega]

Surfaced from Interchain IBC team's review of 08-wasm at hash https://github.com/strangelove-ventures/ibc-go/commit/96e9930ab87a171a3ae6ac9717ee25bfda77212b

Summary

Instead of 08-wasm module being responsible for storing the ClientState and ConsensusState provided in MsgCreateClient, delegate that responsibility to the light client contract.

Problem Definition

The 08-wasm module is not completely a proxy client, since the implementation of Initialize function of the ClientState interface takes care of storing the client state and the consensus state provided in MsgCreateClient, instead of delegating to the light client contract the responsibility to store both (and any other additional metadata).

Proposal

The light client contracts already take care of updating the ClientState and ConsensusState when a ClientMessage is provided in MsgUpdateClient (see UpdateState). Therefore it would make sense that the light client contract does the same thing in Initialize. This also enables the light contracts to set any additional data (e.g. metadata) at light client initialisation.

• Remove setClientState and setConsensusState.
• Implement in light client contract, either in the call to instantiate the contract or in a separate call, the logic to store client state and consensus state.

Tagging @misko9 @blasrodri to hear their thoughts, since this change impacts the contracts.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[crodriguezvega]

Closed by #4033