Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename test chain CurrentHeader to CurrentUncommittedHeader #3973

Closed
3 tasks
colin-axner opened this issue Jun 27, 2023 · 4 comments · Fixed by #5673
Closed
3 tasks

Rename test chain CurrentHeader to CurrentUncommittedHeader #3973

colin-axner opened this issue Jun 27, 2023 · 4 comments · Fixed by #5673
Assignees
@chandiniv1
Labels
change: api breaking Issues or PRs that break Go API (need to be release in a new major version) good first issue Good for newcomers help wanted Issues for which we would appreciate help/support from the community testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
Testing package i...

Comments

@colin-axner
Copy link
Contributor

Summary

Rename test chain CurrentHeader to CurrentUncommittedHeader

similar logic to #3971

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added needs discussion Issues that need discussion before they can be worked on testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces labels Jun 27, 2023
@colin-axner
Copy link
Contributor Author

colin-axner commented Jul 3, 2023 •
edited
Loading

Could also be proposedHeader

Edit: I think I prefer proposed header

@colin-axner colin-axner mentioned this issue Aug 9, 2023
Closed
9 tasks
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Nov 6, 2023
@colin-axner colin-axner added the change: api breaking Issues or PRs that break Go API (need to be release in a new major version) label Nov 7, 2023
@colin-axner
Copy link
Contributor Author

We decided to go with proposedHeader

@colin-axner colin-axner added good first issue Good for newcomers help wanted Issues for which we would appreciate help/support from the community and removed needs discussion Issues that need discussion before they can be worked on labels Jan 15, 2024
@chandiniv1
Copy link
Contributor

@colin-axner can I work on this issue?

@DimitrisJim
Copy link
Contributor

you most definitely can! @chandiniv1

@crodriguezvega crodriguezvega moved this from Backlog to In progress in ibc-go Jan 18, 2024
@chandiniv1 chandiniv1 mentioned this issue Jan 22, 2024
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in ibc-go Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chandiniv1 chandiniv1

Labels
change: api breaking Issues or PRs that break Go API (need to be release in a new major version) good first issue Good for newcomers help wanted Issues for which we would appreciate help/support from the community testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
Testing package improvements
Development

Successfully merging a pull request may close this issue.

rename currentheader to proposedheader chandiniv1/ibc-go
3 participants
@DimitrisJim @colin-axner @chandiniv1