Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin code to the wasm VM cache #4087

Closed
crodriguezvega opened this issue Jul 14, 2023 · 1 comment
Closed

Pin code to the wasm VM cache #4087

crodriguezvega opened this issue Jul 14, 2023 · 1 comment
Labels
08-wasm audit Feedback from implementation audit type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
08-wasm/v0.1.0

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Jul 14, 2023 •
edited
Loading

Surfaced from Confio's review of 08-wasm at hash https://github.com/strangelove-ventures/ibc-go/commit/96e9930ab87a171a3ae6ac9717ee25bfda77212b

See item 6.5 of report (TODO: add link when report is available in ibc-go).

  • After storing the wasm byte code, call k.wasmVM.Pin(codeHash) to pin the code..
  • Add error ErrPinContractFailed with error message pinning contract failed and return errorsmod.Wrap(types.ErrPinContractFailed, err.Error()) in case the pin operation fails.
@crodriguezvega crodriguezvega added audit Feedback from implementation audit type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. 08-wasm labels Jul 14, 2023
@crodriguezvega crodriguezvega added this to the 08-wasm/v1.0.0 milestone Jul 14, 2023
@Reecepbcups Reecepbcups mentioned this issue Jul 15, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to In progress in ibc-go Jul 17, 2023
@crodriguezvega
Copy link
Contributor Author

Closed by #4093

@github-project-automation github-project-automation bot moved this from In progress to Done in ibc-go Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
08-wasm audit Feedback from implementation audit type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Status: Done 🥳
Milestone
08-wasm/v0.1.0
Development

No branches or pull requests
1 participant
@crodriguezvega