You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently missing code coverage for a message failing validate basic, see here. A test case should be added to ensure that check remains there
Edit: ValidateBasic is being called twice. Once by SDK and once by ibc-go, so adding a test case to fail in ibc-go isn't possible. Instead we can change the OnRecvPacket test to use error assertion, so if both checks are removed, the test fails error is assertion
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
Summary
Currently missing code coverage for a message failing validate basic, see here. A test case should be added to ensure that check remains there
Edit:
ValidateBasic
is being called twice. Once by SDK and once by ibc-go, so adding a test case to fail in ibc-go isn't possible. Instead we can change theOnRecvPacket
test to use error assertion, so if both checks are removed, the test fails error is assertionFor Admin Use
The text was updated successfully, but these errors were encountered: