Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use error assertion in ica host execution tests #4145

Closed
3 tasks
colin-axner opened this issue Jul 20, 2023 · 1 comment · Fixed by #4161
Closed
3 tasks

Use error assertion in ica host execution tests #4145

colin-axner opened this issue Jul 20, 2023 · 1 comment · Fixed by #4161
Assignees
Labels
testing Testing package and unit/integration tests

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Jul 20, 2023

Summary

Currently missing code coverage for a message failing validate basic, see here. A test case should be added to ensure that check remains there

Edit: ValidateBasic is being called twice. Once by SDK and once by ibc-go, so adding a test case to fail in ibc-go isn't possible. Instead we can change the OnRecvPacket test to use error assertion, so if both checks are removed, the test fails error is assertion


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the testing Testing package and unit/integration tests label Jul 20, 2023
@DimitrisJim DimitrisJim self-assigned this Jul 24, 2023
@colin-axner colin-axner changed the title Missing code coverage for host chain validate basic call Use error assertion in ica host execution tests Aug 1, 2023
@colin-axner
Copy link
Contributor Author

ref #3778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing package and unit/integration tests
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

2 participants