Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document newStoreAdapter used when calling Contracts #4183

Closed
3 tasks
DimitrisJim opened this issue Jul 26, 2023 · 2 comments
Closed
3 tasks

Document newStoreAdapter used when calling Contracts #4183

DimitrisJim opened this issue Jul 26, 2023 · 2 comments
Labels
08-wasm needs discussion Issues that need discussion before they can be worked on

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Jul 26, 2023

Summary

This was brought up in one of the calls. It appears this was yanked from wasmd, this change in wasmd was done as a result of decoupling wasmvm from tendermint and exposing an interface for the stores it expects. Reference issue CosmWasm/wasmd#1245


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added needs discussion Issues that need discussion before they can be worked on 08-wasm labels Jul 26, 2023
@DimitrisJim
Copy link
Contributor Author

ah, the Iterator interfaces do not match, this needs to stay, I'll document this.

The check for nil does appear to not be required. In wasmd, this store might be nil in the case where an address passed in doesn't belong to a contract (said address is used to calculate the store prefix), see here.

@DimitrisJim DimitrisJim changed the title Remove newStoreAdapter used when calling Contracts Document newStoreAdapter used when calling Contracts Jul 26, 2023
@DimitrisJim
Copy link
Contributor Author

closing this, was done indirectly in other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08-wasm needs discussion Issues that need discussion before they can be worked on
Projects
None yet
Development

No branches or pull requests

1 participant