Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing appmodule.AppModule funcs to each sdk module in ibc-go #4217

Closed
3 tasks
Tracked by #3707
colin-axner opened this issue Aug 1, 2023 · 2 comments
Closed
3 tasks
Tracked by #3707
Labels
good first issue Good for newcomers
Milestone

Comments

@colin-axner
Copy link
Contributor

Summary

v0.50 SDK now has two interfaces:

  • module.AppModule (types package)
  • appmodule.AppModule (core package)

Problem Definition

Our modules in the SDK upgrade feature branch do not implement the second interface causing autocli registration to fail.

Proposal

Add the following functions and compiler assertions to each sdk module in ibc-go (core, transfer, 27-ica, 29-fee):

import       "cosmossdk.io/core/appmodule"

var (
     _ appmodule.AppModule        = (*AppModule)(nil)
)

// IsOnePerModuleType implements the depinject.OnePerModuleType interface.
func (am AppModule) IsOnePerModuleType() {}

// IsAppModule implements the appmodule.AppModule interface.
func (am AppModule) IsAppModule() {}

Remove the following lines of code after. Here and here. Remove the basic manager input argument to each query/tx command function as well.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the v8.0.0 milestone Aug 1, 2023
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Aug 1, 2023
@colin-axner
Copy link
Contributor Author

It might be possible to make this change to main (unsure)

@crodriguezvega
Copy link
Contributor

Closed by #4332

@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

2 participants