Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify upgrade init to only store upgrade fields #4237

Closed
3 tasks
damiannolan opened this issue Aug 2, 2023 · 0 comments
Closed
3 tasks

Modify upgrade init to only store upgrade fields #4237

damiannolan opened this issue Aug 2, 2023 · 0 comments
Assignees
Labels
04-channel channel-upgradability Channel upgradability feature

Comments

@damiannolan
Copy link
Contributor

damiannolan commented Aug 2, 2023

Summary

Update the ChannelUpgradeInit handler to only store the upgrade fields and not the timeout and last packet sequence send.

  • Remove timeout in MsgChannelUpgradeInit and setting in Upgrade
  • Remove setting of last packet sequence sent in Upgrade

This will require updating proof verification of TRY to only verify the upgrade fields set. The MsgChannelUpgradeTry should now take in UpgradeFields instead of an Upgrade for the CounterpartyProposedUpgrade, the field name can be renamed as well


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added 04-channel channel-upgradability Channel upgradability feature labels Aug 2, 2023
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Aug 2, 2023
@damiannolan damiannolan moved this to Todo in ibc-go Aug 2, 2023
@damiannolan damiannolan self-assigned this Aug 7, 2023
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Aug 7, 2023
@damiannolan damiannolan moved this from In progress to On hold in ibc-go Aug 14, 2023
@damiannolan damiannolan moved this from On hold to In review in ibc-go Aug 14, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04-channel channel-upgradability Channel upgradability feature
Projects
Archived in project
Development

No branches or pull requests

1 participant