Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve commented out testcases from timeout logic in channel upgrades #4346

Closed
3 tasks
damiannolan opened this issue Aug 15, 2023 · 0 comments
Closed
3 tasks

resolve commented out testcases from timeout logic in channel upgrades #4346

damiannolan opened this issue Aug 15, 2023 · 0 comments
Assignees
@damiannolan @chatton
Labels
channel-upgradability Channel upgradability feature
Milestone
04-channel upgrad...

Comments

@damiannolan
Copy link
Contributor

Summary

The refactor of channel upgradability causes a number of failing tests specificially due to the the timeout and flushing logic changing on the INIT handler.

#4344 begins the main portion of the refactor and has disabled a number of tests.

This issue can be used to track reinstating the tests and ensuring they run successfully.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added the channel-upgradability Channel upgradability feature label Aug 15, 2023
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Aug 15, 2023
@damiannolan damiannolan mentioned this issue Aug 15, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Aug 20, 2023
@crodriguezvega crodriguezvega moved this from Todo to On hold in ibc-go Aug 20, 2023
@damiannolan damiannolan self-assigned this Aug 23, 2023
@chatton chatton self-assigned this Aug 24, 2023
@chatton chatton mentioned this issue Aug 28, 2023
Merged
9 tasks
@chatton chatton changed the title tracker: resolve commented out testcases from timeout logic in channel upgrades resolve commented out testcases from timeout logic in channel upgrades Aug 28, 2023
@github-project-automation github-project-automation bot moved this from On hold to Done in ibc-go Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

@chatton chatton

Labels
channel-upgradability Channel upgradability feature
Projects
ibc-go
Archived in project
Milestone
04-channel upgrades alpha
Development

No branches or pull requests
2 participants
@damiannolan @chatton