Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate event emission for ibc software upgrades vs an upgraded client #4507

Closed
3 tasks
colin-axner opened this issue Aug 30, 2023 · 1 comment
Closed
3 tasks
Assignees
Milestone

Comments

@colin-axner
Copy link
Contributor

Summary

Currently the same event is used to indicate a IBC software upgrade has been scheduled and that a client has been upgraded.

These are not the same events. One refers to a plan scheduled on the source chain and the other refers to clients upgraded on the counterparty chains. We should differentiate the two by creating a separate event for scheduling an IBC software upgrade. We can start by making a separate function and then see if we can change the type (unsure if this event is used by relayers, but I believe they rely on the emitUpgradeChainEvent instead)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega
Copy link
Contributor

Closed by #4594

@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants