Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update portkey to include portID #451

Closed
3 tasks
seantking opened this issue Sep 29, 2021 · 1 comment
Closed
3 tasks

Update portkey to include portID #451

seantking opened this issue Sep 29, 2021 · 1 comment
Assignees
@damiannolan
Labels
27-interchain-accounts audit Feedback from implementation audit
Milestone
Interchain Accounts

Comments

@seantking
Copy link
Contributor

Summary of Issue

We need to ensure that new ports that get bound are all stored under unique keys so they can be correctly exported/imported for genesis. We can achieve this by updating the portID mapping key to use portKey + portID instead of just the portKey.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking seantking added 27-interchain-accounts audit Feedback from implementation audit labels Sep 29, 2021
@seantking seantking added this to the Interchain Accounts milestone Sep 29, 2021
@damiannolan damiannolan mentioned this issue Oct 5, 2021
Merged
9 tasks
@damiannolan damiannolan self-assigned this Oct 5, 2021
@damiannolan
Copy link
Member

Closed by #467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
27-interchain-accounts audit Feedback from implementation audit
Projects
ibc-go
Archived in project
Milestone
Interchain Accounts
Development

No branches or pull requests
2 participants
@damiannolan @seantking