Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AppModuleBasic interface functions from capability module #4655

Closed
colin-axner opened this issue Sep 13, 2023 · 0 comments · Fixed by #4982
Closed

Remove AppModuleBasic interface functions from capability module #4655

colin-axner opened this issue Sep 13, 2023 · 0 comments · Fixed by #4982
Labels
capability Issues for capability modules type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor 

          I think we can safely remove this assertion and the associated functions, this should be investigated and removed if possible. It may be possible to remove the simulation functions as well

Originally posted by @colin-axner in #4654 (comment)
@colin-axner colin-axner added capability Issues for capability modules type: code hygiene Clean up code but without changing functionality or interfaces labels Sep 13, 2023
This was referenced Oct 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
capability Issues for capability modules type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removing AppModuleBasic from Capability muku314115/ibc-go
1 participant
@colin-axner