Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wasmvm.CreateChecksum instead of duplicating it. #5071

Closed
2 of 3 tasks
DimitrisJim opened this issue Nov 9, 2023 · 0 comments · Fixed by #5123
Closed
2 of 3 tasks

Use wasmvm.CreateChecksum instead of duplicating it. #5071

DimitrisJim opened this issue Nov 9, 2023 · 0 comments · Fixed by #5123
Assignees
@crodriguezvega
Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.

Comments

@DimitrisJim
Copy link
Contributor

Feedback from Simon's peer review:

generateWasmCodeHash is available in wasmvm and can be reused: wasmvm.CreateChecksum.

there's additional places throughout code where we directly call into the sha256 pkg that can additionally be replaced.

Can be done after feature branch is merged.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. 08-wasm labels Nov 9, 2023
@charleenfei charleenfei self-assigned this Nov 10, 2023
@crodriguezvega crodriguezvega moved this to In progress in ibc-go Nov 11, 2023
@crodriguezvega crodriguezvega mentioned this issue Nov 16, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega linked a pull request Nov 16, 2023 that will close this issue
imp: use wasm VM CreateChecksum #5123
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in ibc-go Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crodriguezvega crodriguezvega

Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

imp: use wasm VM CreateChecksum cosmos/ibc-go
3 participants
@crodriguezvega @DimitrisJim @charleenfei