Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call Pin during app inisitalization #5073

Closed
2 of 3 tasks
DimitrisJim opened this issue Nov 9, 2023 · 4 comments · Fixed by #5161
Closed
2 of 3 tasks

Call Pin during app inisitalization #5073

DimitrisJim opened this issue Nov 9, 2023 · 4 comments · Fixed by #5161
Assignees
@vuong177
Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
08-wasm/v0.1.0

Comments

@DimitrisJim
Copy link
Contributor

Feedback from Simon's peer review:

Pin needs to be called on every start. See https://github.com/CosmWasm/wasmd/blob/v0.44.0/app/app.go#L808 for the wasmd equivalent

Can be done after feature branch is merged.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. 08-wasm labels Nov 9, 2023
@vuong177
Copy link
Contributor

@DimitrisJim could I work on this issue ?

@DimitrisJim
Copy link
Contributor Author

You most certainly can @vuong177, thanks!

Do note that it should be worked on after the feature branch for 08-wasm is merged which should be sometime next week. I'll ping you and let you know!

@crodriguezvega crodriguezvega moved this to Todo in ibc-go Nov 11, 2023
@crodriguezvega crodriguezvega added this to the 08-wasm/v0.1.0 milestone Nov 13, 2023
@damiannolan
Copy link
Member

Hi @vuong177, are you still planning to PR this issue? I believe the feature branch has been merged

@vuong177
Copy link
Contributor

@damiannolan yes I'm working on this. I'll make a PR soon !

@vuong177 vuong177 mentioned this issue Nov 22, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega moved this from Todo to In progress in ibc-go Nov 24, 2023
@crodriguezvega crodriguezvega moved this from In progress to In review in ibc-go Nov 27, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vuong177 vuong177

Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
08-wasm/v0.1.0
Development

Successfully merging a pull request may close this issue.

Call Pin during app inisitalization
4 participants
@damiannolan @crodriguezvega @DimitrisJim @vuong177