Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace nil querier with error querier #5281

Closed
3 tasks
colin-axner opened this issue Nov 30, 2023 · 3 comments
Closed
3 tasks

Replace nil querier with error querier #5281

colin-axner opened this issue Nov 30, 2023 · 3 comments
Labels
08-wasm audit Feedback from implementation audit
Milestone
08-wasm/v0.1.0

Comments

@colin-axner
Copy link
Contributor

Summary

From Simon's peer review of 08-wasm:

Create a wasmvm.Querier that returns an error for every request in Query()

This avoids unexpected crashes

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added audit Feedback from implementation audit 08-wasm labels Nov 30, 2023
@colin-axner colin-axner added this to the 08-wasm/v0.1.0 milestone Nov 30, 2023
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Nov 30, 2023
@crodriguezvega
Copy link
Contributor

To be implemented after we merge #5261.

@DimitrisJim DimitrisJim mentioned this issue Nov 30, 2023
Merged
9 tasks
@damiannolan
Copy link
Contributor

I think it would be good to just include this in the one PR (#5261), what do you think?

@DimitrisJim
Copy link
Contributor

closed in #5261

@github-project-automation github-project-automation bot moved this from Todo to Done in ibc-go Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
08-wasm audit Feedback from implementation audit
Projects
ibc-go
Archived in project
Milestone
08-wasm/v0.1.0
Development

No branches or pull requests
4 participants
@damiannolan @crodriguezvega @DimitrisJim @colin-axner