Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call to SetUpgradeErrorReceipt from restoreChannel. #5399

Closed
chatton opened this issue Dec 13, 2023 · 4 comments · Fixed by #5405
Closed

Remove call to SetUpgradeErrorReceipt from restoreChannel. #5399

chatton opened this issue Dec 13, 2023 · 4 comments · Fixed by #5405
Assignees
Labels
channel-upgradability Channel upgradability feature

Comments

@chatton
Copy link
Contributor

chatton commented Dec 13, 2023

Remove call to SetUpgradeErrorReceipt from restoreChannel.

This feels like a side effect, and might be cleaner to call separately afterwards.

Originally posted by @damiannolan in #5237 (comment)

@chatton chatton added the channel-upgradability Channel upgradability feature label Dec 13, 2023
@vishal-kanna
Copy link
Contributor

@chatton Can i work on this issue?

@chatton
Copy link
Contributor Author

chatton commented Dec 13, 2023

sure @vishal-kanna, this one should be going into the 04-channel-upgrades feature branch, thanks!

@vishal-kanna
Copy link
Contributor

@chatton Is it removing the SetUpgradeErrorReceipt from restoreChannel .
Do we need to add it anywhere else?

@chatton
Copy link
Contributor Author

chatton commented Dec 13, 2023

@vishal-kanna yeah we'll need to add it everywhere that restore channel is currently being called to ensure the behaviour is the same. It looks like that is

  1. here
  2. here
  3. And here

There may be some tests that fail after you move these things, I can help out with the refactors of the tests if you run into this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants