Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint to latest version #6086

Closed
2 of 3 tasks
DimitrisJim opened this issue Apr 3, 2024 · 4 comments · Fixed by #6169
Closed
2 of 3 tasks

Bump golangci-lint to latest version #6086

DimitrisJim opened this issue Apr 3, 2024 · 4 comments · Fixed by #6169
Assignees
Labels
github_actions Pull requests that update Github_actions code good first issue Good for newcomers help wanted Issues for which we would appreciate help/support from the community

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Apr 3, 2024

Seems that running the linter (locally) with 1.57.2 leads to many new linting errors popping up, many seem to be due to not checking if a cast to a type is ok (x := y.(type).

We should bump the golangci-lint version in our workflows and address issues it brings up. Until then, installing and using 1.54.2 locally should do the trick.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added good first issue Good for newcomers help wanted Issues for which we would appreciate help/support from the community github_actions Pull requests that update Github_actions code labels Apr 3, 2024
@bznein
Copy link
Contributor

bznein commented Apr 5, 2024

I don't mind taking this if nobody disagrees :) I was already running a newer version and got confused by some errors :)

@DimitrisJim
Copy link
Contributor Author

ay! sure thing, go ahead if you have time!

@bznein
Copy link
Contributor

bznein commented Apr 8, 2024

I definitely underestimated the number of errors shown by the new version :D I'll still work on this, but it's going to take some time :)

@DimitrisJim
Copy link
Contributor Author

ahahah, no worries. This is def not too pressing, just annoying for people running locally. Take a good amount of time for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code good first issue Good for newcomers help wanted Issues for which we would appreciate help/support from the community
Projects
None yet
2 participants