Emit forwarding information in transfer events

[crodriguezvega]

Emit forwarding information in transfer events:

• In sendTransfer
• In OnRecvPacket
• In OnAcknowledgementPacket
• In OnTimeoutPacket

As we have done for tokens and denom, we can emit the JSON-encoded string of the field.

[gjermundgaraba]

I bumped into this a little when doing #6556, as the current OnRecvPacket does not emit any events on async ack. What should the events look like in that scenario?

[damiannolan]

I'd personally lean towards having a separate event for forwarding, at least that is what comes to mind initially...

What do others think? Maybe we can discuss this on Monday?

[DimitrisJim]

agree with Damian, thinking these fields will most likely be empty most of the time considering simple transfers will be majority of cases.

[crodriguezvega]

agree with Damian, thinking these fields will most likely be empty most of the time considering simple transfers will be majority of cases.

Is it not possible to not emit the attribute if the value is empty/nil?

[DimitrisJim]

ah right, guess so. think that would make for more conditional code for us and for event parsers but could do the trick if this information is important for each of the events.

[DimitrisJim]

going to do this after #6618

[crodriguezvega]

Just for reference: we decided to add forwarding information for now to the events mentioned in the description of the issue. We will revisit once we have more context about how these events are used.