New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove helper function usage during forwarding #6722

Closed

3 tasks

DimitrisJim opened this issue Jun 27, 2024 · 0 comments · Fixed by #6730

Closed

3 tasks

Remove helper function usage during forwarding #6722

DimitrisJim opened this issue Jun 27, 2024 · 0 comments · Fixed by #6730

Assignees

Labels

20-transfer type: code hygiene

Milestone

ICS20 v2 (path fo...

Contributor

DimitrisJim commented Jun 27, 2024

Based on review here #6693 (review)

Additional discussion #6574 (comment)

It seems like a good approach for now would be to inline these and refactor them out again if more logic is added to them in the future.

should be done after the feature branch is merged.

For Admin Use

Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned

DimitrisJim added 20-transfer type: code hygiene labels

DimitrisJim mentioned this issue

[FEAT] ICS20-V2 Path Forwarding #6693

Merged

10 tasks

crodriguezvega added this to the ICS20 v2 (path forwarding) RC milestone

DimitrisJim self-assigned this

DimitrisJim mentioned this issue

chore: inline smaller helper functions. #6730

Merged

10 tasks

DimitrisJim closed this as completed in #6730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment