Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 24-host path functions #6882

Closed
3 tasks
damiannolan opened this issue Jul 18, 2024 · 8 comments · Fixed by #7016
Closed
3 tasks

Remove 24-host path functions #6882

damiannolan opened this issue Jul 18, 2024 · 8 comments · Fixed by #7016
Assignees
Labels
core type: code hygiene Clean up code but without changing functionality or interfaces
Milestone

Comments

@damiannolan
Copy link
Member

Summary

Now that MerklePath handles bytes directly we can remove the Path functions in 24-host host.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added core type: code hygiene Clean up code but without changing functionality or interfaces labels Jul 18, 2024
@damiannolan damiannolan added this to the v9.0.0 milestone Jul 18, 2024
@vishal-kanna
Copy link
Contributor

@damiannolan, I would like to work on this issue

@crodriguezvega
Copy link
Contributor

Thank you, @vishal-kanna!

@vishal-kanna
Copy link
Contributor

@crodriguezvega Can you give more info about this issue?

@vishal-kanna
Copy link
Contributor

@crodriguezvega @damiannolan Are these ChannelPath ChannelCapabilityPath ChannelUpgradeErrorPath path functions?

@crodriguezvega
Copy link
Contributor

Hi @vishal-kanna, sorry for the delay. This issue refers to all the ...Path functions in the files _paths.go in the host package. Most of these functions should now only be used once (in the corresponding ...Key function), so the implementation can be moved to the ...Key function and get rid of the ...Path function. However, there might be some functions are used in more than one place, so maybe we need to see where it's best to keep those. You can open a draft PR and we can advise. Thank you for picking this issue!

@colin-axner
Copy link
Contributor

Hi @vishal-kanna. Any updates or questions? As this work is in our current iteration, we would be happy to take over this work if you no longer have the opportunity to complete the issue

@DimitrisJim
Copy link
Contributor

you can try inlining the Path suffixed functions into the Key ones for time being, some of these might still need to exist (capability one iirc) so can be left for now (that one will be removed soon).

We should be able to just do a bytes.Join too but that might get messier and can be done in follow up.

@colin-axner
Copy link
Contributor

Thanks for your interest @vishal-kanna. I decided to complete the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants