Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WriteAcknowledgement must check that fee is enabled #758

Closed
AdityaSripal opened this issue Jan 18, 2022 · 2 comments
Closed

WriteAcknowledgement must check that fee is enabled #758

AdityaSripal opened this issue Jan 18, 2022 · 2 comments
Labels
29-fee
Milestone
Fee middleware alpha

Comments

@AdityaSripal
Copy link
Member

If fee not enabled, just pass call to ics4wrapper without doing custom logic.
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jan 18, 2022
@seantking seantking added this to the Fee Middleware milestone Jan 19, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Jan 24, 2022
@seantking seantking moved this from Todo to On hold in ibc-go Feb 11, 2022
@seantking
Copy link
Contributor

seantking commented Feb 11, 2022 •
edited
Loading

We need to get this #905 fixed first before adding this check. I've put this into the On Hold section on the project board.

@seantking seantking mentioned this issue Feb 21, 2022
Merged
9 tasks
@seantking seantking moved this from On hold to In review in ibc-go Feb 21, 2022
@colin-axner
Copy link
Contributor

closed by #952

Repository owner moved this from In review to Done in ibc-go Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware alpha
Development

No branches or pull requests
3 participants
@seantking @AdityaSripal @colin-axner