Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Misbehaviour and Header interface and rename it to ClientMessage #875

Closed
3 tasks
colin-axner opened this issue Feb 7, 2022 · 2 comments
Closed
3 tasks
Assignees

Comments

@colin-axner
Copy link
Contributor

Summary

Remove misbehaviour interface and use the Header interface instead (they will have the same functions after #874)

Splitting pr recommendation:

PR 1

Rename proto files of light client misbehaviour. For example, in 07-tendermint, Misbehaviour, should become a DuplicateHeightHeader or something like that.

We should have a normal Header and a duplicate height header. A normal header may update the client if it does not validate BFT time and the duplicate height header may prove a fork resulting in the client becoming frozen.

PR 2

Change the API to use Header instead of Misbehaviour


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor Author

Let's merge Header and Misbehaviour and name the interface ClientMessage as @AdityaSripal suggests here

@colin-axner colin-axner moved this from On hold to Todo in ibc-go Mar 10, 2022
@colin-axner colin-axner moved this from Todo to On hold in ibc-go Mar 10, 2022
@colin-axner colin-axner changed the title Remove Misbehaviour interface and replace with Header interface Merge Misbehaviour and Header interface and rename it to ClientMessage Mar 10, 2022
@seantking seantking self-assigned this Mar 11, 2022
@seantking seantking moved this from On hold to In review in ibc-go Mar 11, 2022
@colin-axner
Copy link
Contributor Author

closed by #1107

Repository owner moved this from In review to Done in ibc-go Mar 15, 2022
@crodriguezvega crodriguezvega added this to the 02-client refactor milestone Mar 30, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

3 participants