From 84f771f93ed7593f86bdd43c54e9f4c79de96394 Mon Sep 17 00:00:00 2001 From: Damian Nolan Date: Fri, 5 Aug 2022 14:09:12 +0200 Subject: [PATCH] removing solomachine consensus state nil check and test cases --- .../light-clients/06-solomachine/client_state.go | 4 ---- .../06-solomachine/client_state_test.go | 14 -------------- 2 files changed, 18 deletions(-) diff --git a/modules/light-clients/06-solomachine/client_state.go b/modules/light-clients/06-solomachine/client_state.go index fd660c3785a..29474f0d32b 100644 --- a/modules/light-clients/06-solomachine/client_state.go +++ b/modules/light-clients/06-solomachine/client_state.go @@ -231,10 +231,6 @@ func produceVerificationArgs( return nil, nil, 0, 0, err } - if cs.ConsensusState == nil { - return nil, nil, 0, 0, sdkerrors.Wrap(clienttypes.ErrInvalidConsensus, "consensus state cannot be empty") - } - // sequence is encoded in the revision height of height struct sequence := height.GetRevisionHeight() latestSequence := cs.GetLatestHeight().GetRevisionHeight() diff --git a/modules/light-clients/06-solomachine/client_state_test.go b/modules/light-clients/06-solomachine/client_state_test.go index 89d41b7d18f..68bf15cace9 100644 --- a/modules/light-clients/06-solomachine/client_state_test.go +++ b/modules/light-clients/06-solomachine/client_state_test.go @@ -447,13 +447,6 @@ func (suite *SoloMachineTestSuite) TestVerifyMembership() { }, true, }, - { - "consensus state in client state is nil", - func() { - clientState = solomachine.NewClientState(1, nil, false) - }, - false, - }, { "client state latest height is less than sequence", func() { @@ -665,13 +658,6 @@ func (suite *SoloMachineTestSuite) TestVerifyNonMembership() { }, true, }, - { - "consensus state in client state is nil", - func() { - clientState = solomachine.NewClientState(1, nil, false) - }, - false, - }, { "client state latest height is less than sequence", func() {