From 2cd5c8f89e278747054b8e51ca5fac596c81f0d8 Mon Sep 17 00:00:00 2001 From: Jacob Gadikian Date: Sat, 16 Sep 2023 21:38:24 +0800 Subject: [PATCH 1/3] update protodoc strings --- .../applications/interchain_accounts/controller/v1/tx.proto | 2 +- proto/ibc/applications/interchain_accounts/host/v1/tx.proto | 2 +- proto/ibc/applications/transfer/v1/tx.proto | 2 +- proto/ibc/core/client/v1/tx.proto | 4 ++-- proto/ibc/core/connection/v1/tx.proto | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/proto/ibc/applications/interchain_accounts/controller/v1/tx.proto b/proto/ibc/applications/interchain_accounts/controller/v1/tx.proto index b53b42d8be7..f1830ec787c 100644 --- a/proto/ibc/applications/interchain_accounts/controller/v1/tx.proto +++ b/proto/ibc/applications/interchain_accounts/controller/v1/tx.proto @@ -67,7 +67,7 @@ message MsgUpdateParams { option (gogoproto.goproto_getters) = false; - // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten). + // signer address string signer = 1; // params defines the 27-interchain-accounts/controller parameters to update. diff --git a/proto/ibc/applications/interchain_accounts/host/v1/tx.proto b/proto/ibc/applications/interchain_accounts/host/v1/tx.proto index c6e15ef8b7e..01f327292e9 100644 --- a/proto/ibc/applications/interchain_accounts/host/v1/tx.proto +++ b/proto/ibc/applications/interchain_accounts/host/v1/tx.proto @@ -22,7 +22,7 @@ message MsgUpdateParams { option (gogoproto.goproto_getters) = false; - // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten). + // signer address string signer = 1; // params defines the 27-interchain-accounts/host parameters to update. diff --git a/proto/ibc/applications/transfer/v1/tx.proto b/proto/ibc/applications/transfer/v1/tx.proto index c2ca39977c8..144b95898c5 100644 --- a/proto/ibc/applications/transfer/v1/tx.proto +++ b/proto/ibc/applications/transfer/v1/tx.proto @@ -65,7 +65,7 @@ message MsgUpdateParams { option (gogoproto.goproto_getters) = false; - // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten). + // signer address string signer = 1; // params defines the transfer parameters to update. diff --git a/proto/ibc/core/client/v1/tx.proto b/proto/ibc/core/client/v1/tx.proto index d7f8e2f97a0..9d71fde10ef 100644 --- a/proto/ibc/core/client/v1/tx.proto +++ b/proto/ibc/core/client/v1/tx.proto @@ -129,7 +129,7 @@ message MsgRecoverClient { // client string substitute_client_id = 2; - // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten). + // signer address string signer = 3; } @@ -162,7 +162,7 @@ message MsgUpdateParams { option (gogoproto.goproto_getters) = false; - // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten). + // signer address string signer = 1; // params defines the client parameters to update. diff --git a/proto/ibc/core/connection/v1/tx.proto b/proto/ibc/core/connection/v1/tx.proto index d5465d8709a..252153b38b1 100644 --- a/proto/ibc/core/connection/v1/tx.proto +++ b/proto/ibc/core/connection/v1/tx.proto @@ -133,7 +133,7 @@ message MsgUpdateParams { option (gogoproto.goproto_getters) = false; - // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten). + // signer address string signer = 1; // params defines the connection parameters to update. From b7fb7b187699ba50bd97545ae3b0cbca9941acce Mon Sep 17 00:00:00 2001 From: Jacob Gadikian Date: Sat, 16 Sep 2023 21:40:51 +0800 Subject: [PATCH 2/3] rebuild protos --- modules/apps/27-interchain-accounts/controller/types/tx.pb.go | 2 +- modules/apps/27-interchain-accounts/host/types/tx.pb.go | 2 +- modules/apps/transfer/types/tx.pb.go | 2 +- modules/core/02-client/types/tx.pb.go | 4 ++-- modules/core/03-connection/types/tx.pb.go | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/modules/apps/27-interchain-accounts/controller/types/tx.pb.go b/modules/apps/27-interchain-accounts/controller/types/tx.pb.go index 09c8fc11c89..4bb498300a7 100644 --- a/modules/apps/27-interchain-accounts/controller/types/tx.pb.go +++ b/modules/apps/27-interchain-accounts/controller/types/tx.pb.go @@ -192,7 +192,7 @@ var xxx_messageInfo_MsgSendTxResponse proto.InternalMessageInfo // MsgUpdateParams defines the payload for Msg/UpdateParams type MsgUpdateParams struct { - // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten). + // signer address Signer string `protobuf:"bytes,1,opt,name=signer,proto3" json:"signer,omitempty"` // params defines the 27-interchain-accounts/controller parameters to update. // diff --git a/modules/apps/27-interchain-accounts/host/types/tx.pb.go b/modules/apps/27-interchain-accounts/host/types/tx.pb.go index acbb5c8aa60..ebcc8995cb5 100644 --- a/modules/apps/27-interchain-accounts/host/types/tx.pb.go +++ b/modules/apps/27-interchain-accounts/host/types/tx.pb.go @@ -31,7 +31,7 @@ const _ = proto.GoGoProtoPackageIsVersion3 // please upgrade the proto package // MsgUpdateParams defines the payload for Msg/UpdateParams type MsgUpdateParams struct { - // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten). + // signer address Signer string `protobuf:"bytes,1,opt,name=signer,proto3" json:"signer,omitempty"` // params defines the 27-interchain-accounts/host parameters to update. // diff --git a/modules/apps/transfer/types/tx.pb.go b/modules/apps/transfer/types/tx.pb.go index 14b4b9815d6..3e86ff234e4 100644 --- a/modules/apps/transfer/types/tx.pb.go +++ b/modules/apps/transfer/types/tx.pb.go @@ -130,7 +130,7 @@ var xxx_messageInfo_MsgTransferResponse proto.InternalMessageInfo // MsgUpdateParams is the Msg/UpdateParams request type. type MsgUpdateParams struct { - // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten). + // signer address Signer string `protobuf:"bytes,1,opt,name=signer,proto3" json:"signer,omitempty"` // params defines the transfer parameters to update. // diff --git a/modules/core/02-client/types/tx.pb.go b/modules/core/02-client/types/tx.pb.go index 41954fe8f29..4ddcfb55201 100644 --- a/modules/core/02-client/types/tx.pb.go +++ b/modules/core/02-client/types/tx.pb.go @@ -373,7 +373,7 @@ type MsgRecoverClient struct { // the substitute client identifier for the client which will replace the subject // client SubstituteClientId string `protobuf:"bytes,2,opt,name=substitute_client_id,json=substituteClientId,proto3" json:"substitute_client_id,omitempty"` - // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten). + // signer address Signer string `protobuf:"bytes,3,opt,name=signer,proto3" json:"signer,omitempty"` } @@ -556,7 +556,7 @@ var xxx_messageInfo_MsgIBCSoftwareUpgradeResponse proto.InternalMessageInfo // MsgUpdateParams defines the sdk.Msg type to update the client parameters. type MsgUpdateParams struct { - // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten). + // signer address Signer string `protobuf:"bytes,1,opt,name=signer,proto3" json:"signer,omitempty"` // params defines the client parameters to update. // diff --git a/modules/core/03-connection/types/tx.pb.go b/modules/core/03-connection/types/tx.pb.go index 6995dd78a79..afe87287690 100644 --- a/modules/core/03-connection/types/tx.pb.go +++ b/modules/core/03-connection/types/tx.pb.go @@ -380,7 +380,7 @@ var xxx_messageInfo_MsgConnectionOpenConfirmResponse proto.InternalMessageInfo // MsgUpdateParams defines the sdk.Msg type to update the connection parameters. type MsgUpdateParams struct { - // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten). + // signer address Signer string `protobuf:"bytes,1,opt,name=signer,proto3" json:"signer,omitempty"` // params defines the connection parameters to update. // From fa4c0295dd2ec109078e084a36427ab0a8d39fdf Mon Sep 17 00:00:00 2001 From: Jim Fasarakis-Hilliard Date: Mon, 18 Sep 2023 15:02:56 +0300 Subject: [PATCH 3/3] update signer documentation for MsgIBCSoftwareUpgrade --- proto/ibc/core/client/v1/tx.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto/ibc/core/client/v1/tx.proto b/proto/ibc/core/client/v1/tx.proto index 9d71fde10ef..ee32db9158a 100644 --- a/proto/ibc/core/client/v1/tx.proto +++ b/proto/ibc/core/client/v1/tx.proto @@ -149,7 +149,7 @@ message MsgIBCSoftwareUpgrade { // deprecated in the Cosmos SDK to allow for this logic to exist solely in // the 02-client module. google.protobuf.Any upgraded_client_state = 2; - // signer defaults to the governance account address unless otherwise specified. + // signer address string signer = 3; }