diff --git a/docs/docs/05-migrations/13-v8-to-v9.md b/docs/docs/05-migrations/13-v8-to-v9.md index 6479e64ae63..02d0ae5bcff 100644 --- a/docs/docs/05-migrations/13-v8-to-v9.md +++ b/docs/docs/05-migrations/13-v8-to-v9.md @@ -26,8 +26,8 @@ There are four sections based on the four potential user groups of this document ### API removals -The `exported.ChannelI` and `exported.CounterpartyChannelI` interfaces has been removed. Please use the concrete types. -The `exported.ConnectionI` interface has been removed. Please use the concrete types. +The `exported.ChannelI` and `exported.CounterpartyChannelI` interfaces have been removed. Please use the concrete types. +The `exported.ConnectionI` and `exported.CounterpartyConnectionI` interfaces have been removed. Please use the concrete types. The functions `GetState()`, `GetOrdering()`, `GetCounterparty()`, `GetConnectionHops()`, `GetVersion()` of the `Channel` type have been removed. The functions `GetPortID()`, `GetChannelID()` of the `CounterpartyChannel` type have been removed. diff --git a/modules/core/03-connection/types/codec.go b/modules/core/03-connection/types/codec.go index 9da606deab4..628fbf06526 100644 --- a/modules/core/03-connection/types/codec.go +++ b/modules/core/03-connection/types/codec.go @@ -5,18 +5,11 @@ import ( codectypes "github.com/cosmos/cosmos-sdk/codec/types" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/msgservice" - - "github.com/cosmos/ibc-go/v8/modules/core/exported" ) // RegisterInterfaces register the ibc interfaces submodule implementations to protobuf // Any. func RegisterInterfaces(registry codectypes.InterfaceRegistry) { - registry.RegisterInterface( - "ibc.core.connection.v1.CounterpartyConnectionI", - (*exported.CounterpartyConnectionI)(nil), - &Counterparty{}, - ) registry.RegisterImplementations( (*sdk.Msg)(nil), &MsgConnectionOpenInit{}, diff --git a/modules/core/03-connection/types/codec_test.go b/modules/core/03-connection/types/codec_test.go index 829ca77d7bc..899c258e184 100644 --- a/modules/core/03-connection/types/codec_test.go +++ b/modules/core/03-connection/types/codec_test.go @@ -18,11 +18,6 @@ func TestCodecTypeRegistration(t *testing.T) { typeURL string expPass bool }{ - { - "success: Counterparty", - sdk.MsgTypeURL(&types.Counterparty{}), - true, - }, { "success: MsgConnectionOpenInit", sdk.MsgTypeURL(&types.MsgConnectionOpenInit{}), diff --git a/modules/core/03-connection/types/connection.go b/modules/core/03-connection/types/connection.go index 3c68dd93eab..a3c5fac54c1 100644 --- a/modules/core/03-connection/types/connection.go +++ b/modules/core/03-connection/types/connection.go @@ -26,7 +26,7 @@ func (c ConnectionEnd) GetClientID() string { } // GetCounterparty implements the Connection interface -func (c ConnectionEnd) GetCounterparty() exported.CounterpartyConnectionI { +func (c ConnectionEnd) GetCounterparty() Counterparty { return c.Counterparty } @@ -58,8 +58,6 @@ func (c ConnectionEnd) ValidateBasic() error { return c.Counterparty.ValidateBasic() } -var _ exported.CounterpartyConnectionI = (*Counterparty)(nil) - // NewCounterparty creates a new Counterparty instance. func NewCounterparty(clientID, connectionID string, prefix commitmenttypes.MerklePrefix) Counterparty { return Counterparty{ diff --git a/modules/core/exported/connection.go b/modules/core/exported/connection.go index 00b55913bd0..221096b4ccb 100644 --- a/modules/core/exported/connection.go +++ b/modules/core/exported/connection.go @@ -2,11 +2,3 @@ package exported // LocalhostConnectionID is the sentinel connection ID for the localhost connection. const LocalhostConnectionID string = "connection-localhost" - -// CounterpartyConnectionI describes the required methods for a counterparty connection. -type CounterpartyConnectionI interface { - GetClientID() string - GetConnectionID() string - GetPrefix() Prefix - ValidateBasic() error -}