Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Prost 0.12.0 #145

Closed
hdevalence opened this issue Sep 22, 2023 · 3 comments · Fixed by #150
Closed

Update to Prost 0.12.0 #145

hdevalence opened this issue Sep 22, 2023 · 3 comments · Fixed by #150

Comments

@hdevalence
Copy link

Hi, we'd like to migrate to Prost 0.12.0, but we need to have compatibility across all of our deps. Would it be possible to get an ibc-proto-rs release using prost 0.12.0?
@hdevalence hdevalence mentioned this issue Sep 22, 2023
Closed
@tony-iqlusion
Copy link
Member

tony-iqlusion commented Sep 22, 2023 •
edited
Loading

Notably this release includes a Name trait which can be used to compute the type_url for Any types, when impl'd for a particular Message type: https://docs.rs/prost/latest/prost/trait.Name.html#method.type_url

Unfortunately there isn't yet prost-build automation for generating impls of that trait, but hopefully it's coming soon.

@hdevalence
Copy link
Author

Yes, that's the big reason we're interested in it -- we had our own version of that trait, reorganized all our protos, and are hoping to avoid having to go and update all the type urls manually: penumbra-zone/penumbra#3077 (comment)

@romac
Copy link
Member

romac commented Sep 27, 2023

I'll get to this right after I publish v0.36.0.

@romac romac mentioned this issue Sep 28, 2023
Merged
2 tasks
@romac romac closed this as completed in #150 Oct 4, 2023
ljoss17 added a commit that referenced this issue Oct 10, 2023
@ljoss17
Merge tag 'v0.37.0' into romac/channel-upgrade-only
2c8cf0e 
ibc-proto-rs v0.37.0

*October 4th, 2023*

This release updates `prost` to v0.12 and `tonic` to v0.10,
and makes `serde` an optional dependency, now only enabled with the `serde` feature.

FEATURES:

- Update `prost` to v0.12 and `tonic` to v0.10
  (#145)

IMPROVEMENTS:

- Make `serde` an optional dependency, now only enabled with the `serde` feature
  (#152)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update prost to v0.12 and tonic to v0.10 cosmos/ibc-proto-rs
3 participants
@hdevalence @romac @tony-iqlusion