Implement ICS 721 #167
Merged
Implement ICS 721 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@yito88 would you regenerate protos given that the proto compiler has been revised as of |
yito88
force-pushed
the
yuji/feat/ics721-impl
branch
from
b60972f to
2971bf7
Compare
yito88
commented
Jan 3, 2024
There was a problem hiding this comment.
We just need to address the issue with the cargo doc. It can be patched automatically the same way we do that for the ICS-20:
ibc-proto-rs/tools/proto-compiler/src/cmd/compile.rs
Lines 225 to 231 in aecfe0d
Once that's resolved, everything else appears good, and we can proceed with merging this PR.
Farhad-Shabani
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import proto from https://github.com/bianjieai/nft-transfer for ICS-721