feat: add 08-wasm client proto types
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: add wasm mod to lib.rs
7 tasks
Yeah that's weird given that the proto definitions haven't changed. Possibly because of protoc version indeed. The changes look fine to me though so let's go ahead. |
romac
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #169
Remark
There are changes in the
src/prost/google.protobuf.rsfile. The proto types have been complied using the latest version of thelibprotoc(version = 25.1). I have a feeling that one of our previous PRs might've used an older compiler version. It would be good to give this a quick check on another machine.