Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend ibc::mock types with more data fields #188

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Extend ibc::mock types with more data fields #188

merged 5 commits into from
Feb 1, 2024

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Jan 26, 2024

Closes #186

@rnbguy rnbguy changed the title Extend ibc::mock types with more data fields Extend ibc::mock types with more data fields Jan 26, 2024
@rnbguy
Copy link
Collaborator Author

rnbguy commented Jan 26, 2024

I am a bit confused about how to run the build step. When I run ./scripts/sync-protobuf.sh, I see changes at places other than src/prost/ibc.mock*.rs and src/prost/proto_descriptor.bin 😅

cc @romac @Farhad-Shabani

@Farhad-Shabani
Copy link
Member

I am a bit confused about how to run the build step. When I run ./scripts/sync-protobuf.sh, I see changes at places other than src/prost/ibc.mock*.rs and src/prost/proto_descriptor.bin 😅

cc @romac @Farhad-Shabani

Make sure you are using the latest version of proto compiler (libprotoc v0.25)

@rnbguy
Copy link
Collaborator Author

rnbguy commented Jan 26, 2024

I am using v0.25.1 - do I have to get the latest v0.25.2?

@rnbguy rnbguy mentioned this pull request Jan 30, 2024
Merged
7 tasks
Farhad-Shabani
Farhad-Shabani requested changes Feb 1, 2024
View reviewed changes
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rnbguy for leveling up our mock definition. Left a few comments.

definitions/mock/ibc.mock.proto Outdated Show resolved Hide resolved
definitions/mock/ibc.mock.proto Outdated Show resolved Hide resolved
definitions/mock/ibc.mock.proto Show resolved Hide resolved
definitions/mock/ibc.mock.proto Outdated Show resolved Hide resolved
@Farhad-Shabani
Copy link
Member

I am using v0.25.1 - do I have to get the latest v0.25.2?

Per our discussion, the issue of non-relevant changes should be resolved by placing "google/*" imports under the "ibc/*". Perhaps we later should consider using buf.yaml for linting.

@rnbguy rnbguy force-pushed the 186-extend-ibc-mock-defs branch from fb5fef8 to 574f0bf Compare February 1, 2024 17:27
@rnbguy
Copy link
Collaborator Author

rnbguy commented Feb 1, 2024

@Farhad-Shabani as per our discussion, I simplified the definitions 🙂

Farhad-Shabani
Farhad-Shabani approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @rnbguy. Looks good to me now.

@rnbguy
Copy link
Collaborator Author

rnbguy commented Feb 1, 2024

@Farhad-Shabani thanks for the nits 😅 totally missed them ! I don't have access to this repo - please, go ahead with the merge. 🤝

@Farhad-Shabani Farhad-Shabani merged commit 7643fa3 into cosmos:main Feb 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Farhad-Shabani Farhad-Shabani Farhad-Shabani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend ibc::mock types with more data fields
2 participants
@rnbguy @Farhad-Shabani