MockClientState to RawMockClientState conversion ignores frozen_height

[rnbguy]

Bug Summary

The following implementation ignores frozen_height of MockClientState.

ibc-rs/ibc-testkit/src/testapp/ibc/clients/mock/client_state.rs

Lines 87 to 96 in ee92645

	impl From<MockClientState> for RawMockClientState {
	fn from(value: MockClientState) -> Self {
	RawMockClientState {
	header: Some(RawMockHeader {
	height: Some(value.header.height().into()),
	timestamp: value.header.timestamp.nanoseconds(),
	}),
	}
	}
	}

So, the serialization-deserialization may not work as expected.

Details

For example, the following fails,

let header = MockHeader::new(Height::new(0, 1).unwrap());
let client_state = MockClientState::new(header).with_frozen_height(Height::min(0));
let raw_client_state = RawMockClientState::from(client_state);
let client_state_back = MockClientState::try_from(raw_client_state).unwrap();
assert_eq!(client_state, client_state_back);

We need to update the original ibc.mock definitions on ibc-proto-rs repo and fix the From implementation in this repo.

Version

<= v0.49.1

Tracked by https://github.com/cosmos/ibc-rs/tree/feat/refactor-testkit

Will be fixed by #1068

[rnbguy]

Note: the same happens with MockConsensusState and RawMockConsensusState where it ignores the commitment root.

[gr4yha7]

@rnbguy I can pick this up.

[rnbguy]

sorry, I am already working on this on the feature branch https://github.com/cosmos/ibc-rs/tree/feat/refactor-testkit

[rnbguy]

closed by #1109