Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend client context mock to support more realistic unit testing #114

Closed
4 tasks done
adizere opened this issue Sep 4, 2020 · 0 comments
Closed
4 tasks done

Extend client context mock to support more realistic unit testing #114

adizere opened this issue Sep 4, 2020 · 0 comments
Assignees

Comments

@adizere
Copy link
Contributor

adizere commented Sep 4, 2020

Summary of Bug

Sub-issue of #115.

Currently, the ICS02 mock context supports only 1 client and 1 consensus state for that client:
https://github.com/informalsystems/ibc-rs/blob/cf6c815eb03ddbee811c5220935f8b96c6b48440/modules/src/ics02_client/context_mock.rs#L11-L16

Consequently, this mock permits very limited testing scenarios.

Rough roadmap:

  • extend struct MockClientContext to permit storing multiple consensus_state,
  • extend the same struct to support multiple client_state (indexed by their client_id most likely)
  • add additional testing scenarios to both in ICS02 (create & update client) and ICS03 (init & try handlers)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere self-assigned this Sep 4, 2020
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
* lint and add go linting

* Update go/Makefile

* fix

Co-authored-by: Marko Baricevic <markobaricevic3778@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant