Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modules] 'tests' folder should not be inside 'src' #133

Closed
4 tasks
adizere opened this issue Jun 26, 2020 · 0 comments
Closed
4 tasks

[modules] 'tests' folder should not be inside 'src' #133

adizere opened this issue Jun 26, 2020 · 0 comments
Assignees
@adizere
Labels
O: new-feature Objective: aims to add new feature

Comments

@adizere
Copy link
Contributor

adizere commented Jun 26, 2020

Summary

For the sake of being consistent across this project (and consistent with tendermint-rs), we should not keep helper files for tests (e.g., JSON files) inside src.

Problem Definition

In relayer/cli, and relayer/relay we find that tests folder is separated from the src folder. This separation does not hold for modules where tests are bundled inside src.

Proposal

Move the tests folder from modules/src/tests to modules/tests and update the tests accordingly.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added the O: new-feature Objective: aims to add new feature label Jun 26, 2020
@adizere adizere self-assigned this Jun 26, 2020
adizere referenced this issue in informalsystems/hermes Jul 21, 2020
@adizere
Refactored the location of JSON files for serialization testing (#118).
e50e552
@adizere adizere mentioned this issue Jul 21, 2020
Merged
6 tasks
adizere referenced this issue in informalsystems/hermes Jul 23, 2020
@adizere
Channel query validation & tests & identifier validation fix (#163 #1…
6f89b2d 
…48 #164)

* Refactored the location of JSON files for serialization testing (#118).

* Validation for channel end + tests template; needs more tests (#148).

* Refining tests for channel end.

* Aligned identifier validation with ICS024 & updated tests (#164).

* Added TODO re: version validation; fix VALID_SPECIAL_CHARS to remove space.

* Fixing the TODO for version field validation.
romac referenced this issue in informalsystems/hermes Jul 29, 2020
@adizere @romac
Channel query validation & tests & identifier validation fix (#163 #1…
a24b416 
…48 #164)

* Refactored the location of JSON files for serialization testing (#118).

* Validation for channel end + tests template; needs more tests (#148).

* Refining tests for channel end.

* Aligned identifier validation with ICS024 & updated tests (#164).

* Added TODO re: version validation; fix VALID_SPECIAL_CHARS to remove space.

* Fixing the TODO for version field validation.
hu55a1n1 referenced this issue in hu55a1n1/hermes Sep 13, 2022
@adizere
Channel query validation & tests & identifier validation fix (informa…
40486fe 
…lsystems#163 #148 #164)

* Refactored the location of JSON files for serialization testing (#118).

* Validation for channel end + tests template; needs more tests (#148).

* Refining tests for channel end.

* Aligned identifier validation with ICS024 & updated tests (#164).

* Added TODO re: version validation; fix VALID_SPECIAL_CHARS to remove space.

* Fixing the TODO for version field validation.
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

Labels
O: new-feature Objective: aims to add new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adizere