You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ibc-go performs additional checks on messages, for e.g. -> https://github.com/cosmos/ibc-go/blob/main/modules/core/04-channel/types/msgs.go, that are currently missing on our side.
I think the TryFrom<RawMsg> is a good place for these checks. Would be nice to make all domain message types correct by construction by having private fields and getters along with a ctor that only allows a user to create a valid message instance.
Version
v0.21.1
Acceptance Criteria
All missing validation checks are added.
Sub Issues
The content you are editing has changed. Please copy your edits and refresh the page.
Summary of Bug
ibc-go performs additional checks on messages, for e.g. -> https://github.com/cosmos/ibc-go/blob/main/modules/core/04-channel/types/msgs.go, that are currently missing on our side.
I think the
TryFrom<RawMsg>
is a good place for these checks. Would be nice to make all domain message types correct by construction by having private fields and getters along with a ctor that only allows a user to create a valid message instance.Version
v0.21.1
Acceptance Criteria
All missing validation checks are added.
Sub Issues
Tasks
ClientType
,ClientId
validation checks #621Signer
validation method to include host-specific checks forvalidate()
processes #619For Admin Use
The text was updated successfully, but these errors were encountered: