Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_acknowledgement handler incorrectly uses packet's source_{port, channel} as key for storing acks #35

Closed
5 tasks
hu55a1n1 opened this issue Jul 19, 2022 · 0 comments
Assignees
Labels
A: bug Admin: something isn't working

Comments

@hu55a1n1
Copy link
Contributor

hu55a1n1 commented Jul 19, 2022

Summary of Bug

modules/src/core/ics04_channel/handler/write_acknowledgement::process incorrectly uses packet's source_{port, channel} instead of dest_{port, channel} as key for storing acks. See spec -> https://github.com/cosmos/ibc/tree/master/spec/core/ics-004-channel-and-packet-semantics#writing-acknowledgements

function writeAcknowledgement(
  packet: Packet,
  acknowledgement: bytes) {
    // ...
    
    // write the acknowledgement
    provableStore.set(
      packetAcknowledgementPath(packet.destPort, packet.destChannel, packet.sequence), // <--------- here
      hash(acknowledgement)
    )
    
    // ...

Version

v0.16.0

Acceptance Criteria

write_acknowledgement handler is fixed to use the appropriate port/channel ids.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1 hu55a1n1 added the A: bug Admin: something isn't working label Jul 19, 2022
@hu55a1n1 hu55a1n1 self-assigned this Jul 19, 2022
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant