Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serde implementations for ICS20 packet data structures are incorrect #38

Closed
7 tasks
hu55a1n1 opened this issue Jul 11, 2022 · 0 comments · Fixed by informalsystems/hermes#2389
Closed
7 tasks

serde implementations for ICS20 packet data structures are incorrect #38

hu55a1n1 opened this issue Jul 11, 2022 · 0 comments · Fixed by informalsystems/hermes#2389
Assignees
@hu55a1n1
Labels
A: bug Admin: something isn't working

Comments

@hu55a1n1
Copy link
Contributor

hu55a1n1 commented Jul 11, 2022 •
edited
Loading

Summary of Bug

ICS20 Acknowledgement and PacketData structs are not (de)serialized correctly.

Version

v0.16.0

Acceptance Criteria

  • The Acknowledgement type must be able to deserialize a string of the form ->
{"result":"AQ=="}
// OR 
{"error":"cannot unmarshal ICS-20 transfer packet data"}
  • The PacketData type must be (de)serialized using the TryFrom/Into<RawPacketData> implementations.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1 hu55a1n1 added the A: bug Admin: something isn't working label Jul 11, 2022
@hu55a1n1 hu55a1n1 self-assigned this Jul 11, 2022
@hu55a1n1 hu55a1n1 mentioned this issue Jul 11, 2022
Merged
6 tasks
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hu55a1n1 hu55a1n1

Labels
A: bug Admin: something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix serde implementations for ICS20 packet data structures informalsystems/hermes
1 participant
@hu55a1n1