Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate moving verify_delay_passed to a more appropriate section #404

Closed
Tracked by #173
Farhad-Shabani opened this issue Feb 8, 2023 · 0 comments · Fixed by #498
Closed
Tracked by #173

Investigate moving verify_delay_passed to a more appropriate section #404

Farhad-Shabani opened this issue Feb 8, 2023 · 0 comments · Fixed by #498
Assignees
Labels
A: breaking Admin: breaking change that may impact operators O: logic Objective: aims for better implementation logic O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Summary

Context: #393 (comment)
The implemented verify_delay_passed method inside the 07_tendermint doesn't seem a client-specific process and it should be placed somewhere in the "connection" part of the stack. The issue arose because we wanted to stop passing the ctx field into some of the verification methods like verify_packet_acknowledgement

@Farhad-Shabani Farhad-Shabani added the O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding label Feb 8, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Feb 8, 2023
@Farhad-Shabani Farhad-Shabani added the O: logic Objective: aims for better implementation logic label Mar 4, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.32.0 milestone Mar 4, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Mar 4, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to 🔖 Needs Review in ibc-rs Mar 4, 2023
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Mar 4, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Needs Review to ✅ Done in ibc-rs Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: breaking Admin: breaking change that may impact operators O: logic Objective: aims for better implementation logic O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant