Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test NO-OP paths for packet acks, RecvPacket and timeouts #427

Open
Tracked by #554
plafer opened this issue Feb 13, 2023 · 2 comments
Open
Tracked by #554

Test NO-OP paths for packet acks, RecvPacket and timeouts #427

plafer opened this issue Feb 13, 2023 · 2 comments
Assignees
@rnbguy
Labels
O: testing Objective: aims to improve testing coverage

Comments

@plafer
Copy link
Contributor

plafer commented Feb 13, 2023

This path for example (and analogous paths for acks and RecvPacket), test that event is emitted properly, and no state change is applied.
@cosmos cosmos deleted a comment Feb 14, 2023
@Farhad-Shabani Farhad-Shabani added the O: testing Objective: aims to improve testing coverage label Feb 14, 2023
@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs Feb 14, 2023
@plafer
Copy link
Contributor Author

plafer commented Feb 17, 2023

#430 implements all tests except for RecvPacket

@Farhad-Shabani Farhad-Shabani mentioned this issue Mar 17, 2023
Open
@rnbguy
Copy link
Collaborator

rnbguy commented Apr 8, 2024

@Farhad-Shabani am I correct to assume we need a test for already submitted packets and make sure there was no change in the state?

As plafer commented, the other tests should be present already.

@rnbguy rnbguy self-assigned this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnbguy rnbguy

Labels
O: testing Objective: aims to improve testing coverage
Projects
ibc-rs
Status: 📥 To Do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rnbguy @plafer @Farhad-Shabani