Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockContext::validate_self_client() should have an implementation #432

Closed
plafer opened this issue Feb 15, 2023 · 1 comment · Fixed by #437
Closed

MockContext::validate_self_client() should have an implementation #432

plafer opened this issue Feb 15, 2023 · 1 comment · Fixed by #437
Assignees
@Farhad-Shabani
Labels
A: bug Admin: something isn't working
Milestone
v0.29.0

Comments

@plafer
Copy link
Contributor

plafer commented Feb 15, 2023 •
edited
Loading

Here. We only need to use the implementation in ibc-rs.
@plafer plafer added the A: bug Admin: something isn't working label Feb 15, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Feb 15, 2023
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani self-assigned this Feb 15, 2023
@Farhad-Shabani Farhad-Shabani moved this to 🏗️ In Progress in ibc-rs Feb 15, 2023
@plafer
Copy link
Contributor Author

plafer commented Feb 16, 2023

Oops, I meant to open this on the basecoin-rs repo (note that the link points there). I'll open one there; we can still keep your MockContext implementation though!

@plafer plafer changed the title ValidationContext::validate_self_client() should have an implementation MockContext::validate_self_client() should have an implementation Feb 16, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs Feb 17, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.29.0 milestone Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Farhad-Shabani Farhad-Shabani

Labels
A: bug Admin: something isn't working
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.29.0
Development

Successfully merging a pull request may close this issue.

Add an implementation of "validate_self_client" for MockContext cosmos/ibc-rs
2 participants
@plafer @Farhad-Shabani