Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable token transfer app to store a map of trace hash with the associated denom #502

Closed
Tracked by #431
Farhad-Shabani opened this issue Mar 7, 2023 · 0 comments · Fixed by #512
Closed
Tracked by #431

Enable token transfer app to store a map of trace hash with the associated denom #502

Farhad-Shabani opened this issue Mar 7, 2023 · 0 comments · Fixed by #512
Assignees
@Farhad-Shabani
Labels
A: breaking Admin: breaking change that may impact operators O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Milestone
v0.32.0

Comments

@Farhad-Shabani
Copy link
Member

Sumary

The current process_recv_packet_execute doesn't store a map for trace_hash and denom. It only returns the pair as an event. Also, send_transfer_execute doesn't restore the original denom with the trace_hash.
This facility exists on IBC-go which makes it possible to store the denom when receiving and restore the denom from the trace hash.

Remark: This facility requested by Namada
@Farhad-Shabani Farhad-Shabani added A: breaking Admin: breaking change that may impact operators O: usability Objective: aims to enhance user experience (UX) and streamline product usability labels Mar 7, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.32.0 milestone Mar 7, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Mar 7, 2023
@Farhad-Shabani Farhad-Shabani moved this to 🏗️ In Progress in ibc-rs Mar 7, 2023
This was referenced Mar 7, 2023
Closed
Merged
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs Mar 9, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Farhad-Shabani Farhad-Shabani

Labels
A: breaking Admin: breaking change that may impact operators O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.32.0
1 participant
@Farhad-Shabani