Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating timeout failed when height timeout #555

Closed
yito88 opened this issue Mar 17, 2023 · 0 comments · Fixed by #556
Closed

Validating timeout failed when height timeout #555

yito88 opened this issue Mar 17, 2023 · 0 comments · Fixed by #556
Labels
A: bug Admin: something isn't working
Milestone

Comments

@yito88
Copy link
Contributor

yito88 commented Mar 17, 2023

Bug Summary

If timeout_height_on_b in a packet reached, the timeout handling failed.

Details

The handling returns PacketTimeoutHeightNotReached error if the timeout height has passed.

        if msg
            .packet
            .timeout_height_on_b
            .has_expired(msg.proof_height_on_b)
        {
            return Err(PacketError::PacketTimeoutHeightNotReached {
                timeout_height: msg.packet.timeout_height_on_b,
                chain_height: msg.proof_height_on_b,
            }
            .into());
        }

It should return an error only when both the timeout height and timestamp have not been reached.

Version

0.32.0

@yito88 yito88 changed the title Handling timeout failed when height timeout Validating timeout failed when height timeout Mar 17, 2023
@Farhad-Shabani Farhad-Shabani moved this to ✅ Done in ibc-rs Mar 27, 2023
@Farhad-Shabani Farhad-Shabani added the A: bug Admin: something isn't working label Mar 27, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.35.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants