Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance abstraction of Acknowledgement result to get accessible by all IBC apps #717

Closed
Tracked by #576
Farhad-Shabani opened this issue Jun 15, 2023 · 1 comment · Fixed by #737
Closed
Tracked by #576

Enhance abstraction of Acknowledgement result to get accessible by all IBC apps #717

Farhad-Shabani opened this issue Jun 15, 2023 · 1 comment · Fixed by #737
Assignees
@Farhad-Shabani
Labels
A: breaking Admin: breaking change that may impact operators O: decoupling Objective: aims to separate concerns and cause to independent, reusable components O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Milestone
v0.43.1

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Jun 15, 2023 •
edited
Loading

Background

For every IBC application on the module callback, especially during the on_recv_packet process, there can be an acknowledgment result (either a success or an error). Currently, we use TokenTransferAcknowledgement enum specifically for the ICS20. To avoid redundancy and looking at the places and how IBC-go handles the Acknowledgment, it is recommended to generalize this abstraction and place it under the ics04_channel section, making it accessible for any application.

This is necessary for the ICS27 implementation.
@Farhad-Shabani Farhad-Shabani added A: breaking Admin: breaking change that may impact operators O: usability Objective: aims to enhance user experience (UX) and streamline product usability O: decoupling Objective: aims to separate concerns and cause to independent, reusable components labels Jun 15, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Jun 15, 2023
This was referenced Jun 27, 2023
Open
Merged
@Farhad-Shabani Farhad-Shabani self-assigned this Jun 30, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to 🏗️ In Progress in ibc-rs Jun 30, 2023
@plafer
Copy link
Contributor

plafer commented Jul 6, 2023

This is necessary for the ICS27 implementation.

Can you explain why? Does ICS27 rely on a particular structure of the Acknowledgement?

@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs Jul 7, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.43.1 milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Farhad-Shabani Farhad-Shabani

Labels
A: breaking Admin: breaking change that may impact operators O: decoupling Objective: aims to separate concerns and cause to independent, reusable components O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.43.1
Development

Successfully merging a pull request may close this issue.

imp: organize acknowledgement types under the ics04_channel cosmos/ibc-rs
2 participants
@plafer @Farhad-Shabani