Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ics23/serde" add to serde feature, so ibc-rs serde feature can't use on no-std env #753

Closed
DaviRain-Su opened this issue Jul 10, 2023 · 3 comments · Fixed by #790
Closed
Assignees
Labels
S: no-std Scope: support no_std envs
Milestone

Comments

@DaviRain-Su
Copy link
Contributor

DaviRain-Su commented Jul 10, 2023

Feature Summary

relate:

Proposal

@dzmitry-lahoda
Copy link
Contributor

I have this issue

error[E0433]: failed to resolve: use of undeclared crate or module `std`
    --> /home/dz/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ics23-0.10.1/src/cosmos.ics23.v1.serde.rs:1860:85
     |
1860 | ...ormatter<'_>) -> std::fmt::Result {
     |                     ^^^ use of undeclared crate or module `std`

error[E0433]: failed to resolve: use of undeclared crate or module `std`
    --> /home/dz/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ics23-0.10.1/src/cosmos.ics23.v1.serde.rs:1865:59
     |
1865 | ... value: &str) -> std::result::Result<GeneratedField, E>
     |                     ^^^ use of undeclared crate or module `std`

error[E0433]: failed to resolve: use of undeclared crate or module `std`
    --> /home/dz/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ics23-0.10.1/src/cosmos.ics23.v1.serde.rs:1886:49
     |
1886 | ... formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
     |                     ^^^ use of undeclared crate or module `std`

@DaviRain-Su
Copy link
Contributor Author

ye, you use ics23 serde feature, but this feature on enable std, cannot work on no_std.

@dzmitry-lahoda
Copy link
Contributor

NO. serde works perfect without STD.

@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Aug 1, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Aug 22, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to 🏗️ In Progress in ibc-rs Aug 22, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs Aug 23, 2023
@Farhad-Shabani Farhad-Shabani added the S: no-std Scope: support no_std envs label Sep 7, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.45.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: no-std Scope: support no_std envs
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants