Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp and duration units should be specified in English specs #572

Open
soareschen opened this issue May 11, 2021 · 0 comments
Open
Labels
from-review Feedback / alterations from specification review.

Comments

@soareschen
Copy link

There are a number of places in the English specs that use u64 as timestamp or duration fields, but with the unit unspecified. One would have to look into the protobuf definitions and the Go code in ibc-go to figure out that the proper unit is in nanoseconds. This can easily cause misinterpretation, and cause the field to be processed in incorrect units such as seconds. (informalsystems/hermes#927)

We should at least clarify in the specs that the relevant u64 fields are in nanoseconds unit. Or if breaking change is possible, we should instead follow Tendermint and use Google.Protobuf.WellKnownTypes.Timestamp and Google.Protobuf.WellKnownTypes.Duration to encode timestamp and duration fields.

@mpoke mpoke added the from-review Feedback / alterations from specification review. label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from-review Feedback / alterations from specification review.
Projects
None yet
Development

No branches or pull requests

2 participants