From e3fe78a36595b3d1ea595026f32e8846701107fb Mon Sep 17 00:00:00 2001 From: Aditya Sripal Date: Thu, 7 Jul 2022 13:15:44 +0200 Subject: [PATCH] make changes to ics721 spec based on #629 --- spec/app/ics-721-nft-transfer/README.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/spec/app/ics-721-nft-transfer/README.md b/spec/app/ics-721-nft-transfer/README.md index d5a9424a6..fb41151e6 100644 --- a/spec/app/ics-721-nft-transfer/README.md +++ b/spec/app/ics-721-nft-transfer/README.md @@ -212,11 +212,13 @@ function onChanOpenInit( channelIdentifier: Identifier, counterpartyPortIdentifier: Identifier, counterpartyChannelIdentifier: Identifier, - version: string) { + version: string) (version: string, err: Error) { // only unordered channels allowed abortTransactionUnless(order === UNORDERED) // assert that version is "ics721-1" - abortTransactionUnless(version === "ics721-1") + // or relayer passed in empty version + abortTransactionUnless(version === "ics721-1" || version === "") + return "ics721-1", nil } ``` @@ -228,11 +230,12 @@ function onChanOpenTry( channelIdentifier: Identifier, counterpartyPortIdentifier: Identifier, counterpartyChannelIdentifier: Identifier, - counterpartyVersion: string) { + counterpartyVersion: string) (version: string, err: Error) { // only unordered channels allowed abortTransactionUnless(order === UNORDERED) // assert that version is "ics721-1" abortTransactionUnless(counterpartyVersion === "ics721-1") + return "ics721-1", nil } ```