From 1b5183c96a40921a2ba5ac06f033db6a13657329 Mon Sep 17 00:00:00 2001 From: nhpd Date: Tue, 5 Sep 2023 15:18:26 +0400 Subject: [PATCH] fix: remove validation for provider chain address since we cannot validate it properly on consumer --- x/ccv/consumer/types/params_test.go | 4 ---- x/ccv/types/params.go | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/x/ccv/consumer/types/params_test.go b/x/ccv/consumer/types/params_test.go index 1690fc9f81..ff5d0f325f 100644 --- a/x/ccv/consumer/types/params_test.go +++ b/x/ccv/consumer/types/params_test.go @@ -29,10 +29,6 @@ func TestValidateParams(t *testing.T) { "custom invalid params, dist transmission channel", ccvtypes.NewParams(true, 5, "badchannel/", "", 5, 1005, "0.5", 1000, 24*21*time.Hour, "0.05", []string{"untrn"}, []string{"uatom"}), false, }, - { - "custom invalid params, provider fee pool addr string", - ccvtypes.NewParams(true, 5, "", "imabadaddress", 5, 1005, "0.5", 1000, 24*21*time.Hour, "0.05", []string{"untrn"}, []string{"uatom"}), false, - }, { "custom invalid params, ccv timeout", ccvtypes.NewParams(true, 5, "", "", -5, 1005, "0.5", 1000, 24*21*time.Hour, "0.05", []string{"untrn"}, []string{"uatom"}), false, diff --git a/x/ccv/types/params.go b/x/ccv/types/params.go index e8ea0a8765..35cd9c5025 100644 --- a/x/ccv/types/params.go +++ b/x/ccv/types/params.go @@ -179,8 +179,8 @@ func ValidateProviderFeePoolAddrStr(i interface{}) error { if i == "" { return nil } - // Otherwise validate as usual for a bech32 address - return ValidateBech32(i) + // Cannot validate provider chain address on the consumer chain + return nil } func ValidateSoftOptOutThreshold(i interface{}) error {