Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaguely named consumer structs #1206

Closed
shaspitz opened this issue Aug 15, 2023 · 0 comments · Fixed by #1288
Closed

Vaguely named consumer structs #1206

shaspitz opened this issue Aug 15, 2023 · 0 comments · Fixed by #1288
Assignees
Labels
good first issue Good for newcomers S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) type: refactoring Code refactoring

Comments

@shaspitz
Copy link
Contributor

Problem

Following the merge of #1071, the consumer's GenesisState and Params will now live in the shared /x/ccv/types directory, as they should be (ie. they're reffed by both consumer and provider). These two structs should now be named ConsumerGenesisState and ConsumerParams since the package alias will no longer indicate the structs are relevant to consumer.

For consistency, we could also refactor the provider structs to be ProviderGenesisState and ProviderParams, although this isn't strictly neccessary as those structs still live in x/ccv/provider.

Closing criteria

Refactor names according to above.

@shaspitz shaspitz added status: waiting-triage This issue/PR has not yet been triaged by the team. type: refactoring Code refactoring labels Aug 15, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Aug 15, 2023
@shaspitz shaspitz moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Aug 15, 2023
@shaspitz shaspitz added good first issue Good for newcomers and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Aug 15, 2023
@bermuell bermuell self-assigned this Sep 12, 2023
@mpoke mpoke moved this from 📥 F2: Todo to 🏗 F3: InProgress in Cosmos Hub Sep 12, 2023
@mpoke mpoke added the S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) label Sep 14, 2023
@bermuell bermuell moved this from 🏗 F3: InProgress to 👀 F3: InReview in Cosmos Hub Sep 15, 2023
@github-project-automation github-project-automation bot moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Sep 15, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) type: refactoring Code refactoring
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants