Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccv consumer genesis transform should use default value for retry_delay_period #1457

Closed
bermuell opened this issue Nov 28, 2023 · 0 comments · Fixed by #1458
Closed

ccv consumer genesis transform should use default value for retry_delay_period #1457

bermuell opened this issue Nov 28, 2023 · 0 comments · Fixed by #1458
Assignees
Labels
S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates)

Comments

@bermuell
Copy link
Contributor

bermuell commented Nov 28, 2023

Problem

The CLI to transformation consumer genesis parameters from older provider versions does not use
default parameter values if the parameter did not exist at that source version.
For parameters such as retry_delay_period this results in an invalid value and prevents consumer to start.

Closing criteria

To reproduce:

  • convert 'consumer-genesis' export from provider version 2.1.0 with transformation command
    interchain-security-cd genesis transform <exported_consumer_genesis.json>
  • extend genesis file of consumer chain with exported json content from previous step
  • start consumer chain

Problem details

When converting consumer genesis parameters exported from a provider chain running an older version to the current version,
parameters which were not defined are populated with the default value of the type.
For the parameter retry_delay_period this results in value 0 which is invalid period and reject.

@bermuell bermuell added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Nov 28, 2023
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Nov 28, 2023
@bermuell bermuell self-assigned this Nov 28, 2023
@bermuell bermuell added the S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) label Nov 28, 2023
@github-project-automation github-project-automation bot moved this from 🩹 F1: Triage to 👍 F4: Assessment in Cosmos Hub Nov 28, 2023
@bermuell bermuell removed the status: waiting-triage This issue/PR has not yet been triaged by the team. label Nov 28, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates)
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant