Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap names of 'integration' and 'e2e' tests #359

Closed
danwt opened this issue Sep 20, 2022 · 4 comments · Fixed by #681
Closed

Swap names of 'integration' and 'e2e' tests #359

danwt opened this issue Sep 20, 2022 · 4 comments · Fixed by #681
Assignees
@sainoe
Labels
good first issue Good for newcomers scope: testing Code review, testing, making sure the code is following the specification. type: refactoring Code refactoring type: tech-debt Slows down development in the long run

Comments

@danwt
Copy link
Contributor

danwt commented Sep 20, 2022

Problem

Currently our 'integration tests' are really more like e2e tests and our 'e2e tests' are really more like integration tests.

Closing criteria

Swap the names of these two things
@danwt danwt added good first issue Good for newcomers scope: testing Code review, testing, making sure the code is following the specification. type: tech-debt Slows down development in the long run type: refactoring Code refactoring labels Sep 20, 2022
@jtremback
Copy link
Contributor

Bikeshedding, and will confuse everyone for a while after the switch

@danwt
Copy link
Contributor Author

danwt commented Sep 21, 2022

🤷

@danwt
Copy link
Contributor Author

danwt commented Oct 19, 2022

I suggest we reopen this. It's confusing people! I've just spoken with @ivan-gavran and heard it!

I don't think it would take long to fix.

@danwt danwt reopened this Oct 19, 2022
@mpoke mpoke moved this to Todo in Replicated Security Dec 20, 2022
@mpoke mpoke added this to Cosmos Hub Jan 17, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jan 17, 2023
@mpoke mpoke added this to the ICS v1.0.0 milestone Jan 17, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Jan 18, 2023
@mpoke
Copy link
Contributor

mpoke commented Jan 18, 2023

Requirements:

  • changing names
  • informing users of testing framework

@sainoe sainoe mentioned this issue Jan 25, 2023
Merged
3 tasks
@sainoe sainoe moved this from 📥 Todo to 🏗 In progress in Cosmos Hub Jan 26, 2023
@mpoke mpoke modified the milestones: ICS v1.0.0 , ICS v1.0.1 Feb 23, 2023
@mpoke mpoke modified the milestones: ICS v1.0.1, ICS next release Mar 5, 2023
@mpoke mpoke moved this from 🏗 In progress to 🛑 Blocked in Cosmos Hub Mar 9, 2023
@mpoke mpoke added this to the Gaia v10.0.0 milestone Mar 13, 2023
@mpoke mpoke moved this from 🛑 Blocked to 🏗 In progress in Cosmos Hub Mar 14, 2023
@mpoke mpoke moved this from 🏗 In progress to 👀 In review in Cosmos Hub Mar 22, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainoe sainoe

Labels
good first issue Good for newcomers scope: testing Code review, testing, making sure the code is following the specification. type: refactoring Code refactoring type: tech-debt Slows down development in the long run
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: swap name of 'e2e' and 'integration' tests cosmos/interchain-security
4 participants
@jtremback @mpoke @sainoe @danwt