Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

difftest core: Amend diff model with throttle changes once spec has been updated #534

Closed
2 tasks done
Tracked by #1528
danwt opened this issue Nov 30, 2022 · 7 comments
Closed
2 tasks done
Tracked by #1528
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: MBT model based testing scope: testing Code review, testing, making sure the code is following the specification.

Comments

@danwt
Copy link
Contributor

danwt commented Nov 30, 2022

Problem

The slash throttle PR changes the way things work when there are a lot of incoming slash requests. The diff test model should be changed to account for this, after the upstream canonical spec has been changed.

Closing criteria

After the ICS spec has been updated to account for throttling, the diff model should be updated to match.

Problem details

See

TODOs

  • Labels have been added for issue
  • Issue has been added to the ICS project
@danwt danwt self-assigned this Nov 30, 2022
@danwt danwt added scope: testing Code review, testing, making sure the code is following the specification. spec scope: MBT model based testing labels Nov 30, 2022
@danwt
Copy link
Contributor Author

danwt commented Nov 30, 2022

cc @smarshall-spitzbart

@shaspitz
Copy link
Contributor

@mpoke @MSalopek I see this is marked as high priority. Which issue should I put effort into first: this one, or #615?

@mpoke
Copy link
Contributor

mpoke commented Jan 25, 2023

@smarshall-spitzbart This one should have priority as the other is just documentation.

@mpoke mpoke moved this from 📥 Todo to 🏗 In progress in Cosmos Hub Jan 26, 2023
@mpoke mpoke self-assigned this Jan 26, 2023
@shaspitz
Copy link
Contributor

It might be beneficial to introduce all throttle related changes to the ICS spec before tackling this issue

@mpoke
Copy link
Contributor

mpoke commented Feb 23, 2023

@smarshall-spitzbart is this issue fixed?

@mpoke mpoke modified the milestones: ICS v1.0.0 , ICS v1.0.1 Feb 23, 2023
@shaspitz
Copy link
Contributor

@smarshall-spitzbart is this issue fixed?

This issue hasn't been completed. Maybe it's being worked on by @sainoe or @MSalopek? Lmk if I should make this my priority

@mpoke mpoke removed this from the ICS v1.0.1 milestone Mar 5, 2023
@mpoke mpoke moved this from 🏗 In progress to 📥 Todo in Cosmos Hub Mar 5, 2023
@mpoke mpoke moved this from 📥 Todo to 🛑 Blocked in Cosmos Hub Jun 20, 2023
@mpoke mpoke added the S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth label Sep 12, 2023
@mpoke mpoke moved this from 🛑 F3: OnHold to 🤔 F1: Investigate in Cosmos Hub Sep 12, 2023
@mpoke mpoke moved this from 🤔 F1: Investigate to 📥 F2: Todo in Cosmos Hub Sep 12, 2023
@p-offtermatt
Copy link
Contributor

Closing since difftest model was deprecated in favor of MBT, may reopen if we want this in the MBT model

@p-offtermatt p-offtermatt closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2024
@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Feb 15, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: MBT model based testing scope: testing Code review, testing, making sure the code is following the specification.
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants